Refunds again (Page 1 of 2)

Looks like I have sorted some issues except one.

I cannot get supplier and customers names plus country comboboxes values on frmRefund after clicking on issue refund buttons (both Purchase and sale refund) on Form1 as highlighted on the screen cap below:

Please see the updated sample project below.

Hi EHW,

Thank you very much...................................
Truly appreciated.............................................

If you and Derek weren't around, probably I'd have been forced to give up on MVD and most likely start with Java from zero.

Hi Adam, EHW,
I've added two lines to the script (234 and 305) which I think addresses the issue you were having.  Hopefully, it doesn't mess anything else up that you've been working on.
I haven't made the same changes for the cbpirtaxpi, cbpirtaxrate, cbsirtaxratesi and cbsirtaxrate fields on the amend purchase refunds and amend sales refunds form as I don't understand why you need to show them;  they aren't saved to the refund table, therefore presumably they must be the same as the cbpirtaxrate field which is already being displayed.  So wouldn't it just be 4 unnecessary calls that will slow things down a bit?
Maybe I'm missing something (wouldn't be the first time - LOL)!.
Regards,
Derek

Adam,

I'm in agreement with Derek. Not sure why you need to display the same field three times on the same form. Since there is only one tax field recorded, I basically put the same dbitemid, populated by Derek, into the other two tax fields on the refund form. The two lines follow Derek's lines.

As far as your other issues, I was not able to replicate them. I did notice that on one of your search buttons you were displaying the Tax.Id rather than the TaxRate. I changed that for you.

Hi Adam, EHW,
With regard to your issue with the 'all refunds' button, it stops working once you've viewed or edited a refund (viewing and editing invoices is fine).  To get the 'all refunds button working again, you either have to restart the program OR click on an invoice that doesn't have any associated refunds, so something is not getting cleared properly.
But I'm not sure why you need a 'search' associated with the 'all refunds' button if you're displaying everything.  A 'quick and dirty' way that I could think of was simply to add a hidden grid that is displayed when you click on 'all refunds' and hidden again when you click back in the invoices tables (see attached).  But there's probably a 'proper' way to do it which I'll try and have a look at.
Just a word of caution, but with possibly 3 of us looking at it independently, you need to be careful that we don't end up overwriting each others' changes.
If I get time, I'll have a think about  the other 2 issues you mentioned as well.
Regards,
Derek.

Hi Adam,
The problem with trying to edit a refund directly from the 'all refunds' grid is that it you haven't highlighted a record in the 'invoices' grid  in the first place (as you would normally do to see refunds for a specific invoice) and so you can't easily get the tax rate (which is only held on the invoice and not on the refund - sounds familiar!).  You'd need to do a double read - once of the refund record to get the associated invoice and then read the associated invoice to get the tax rate.
This problem largely goes away if you don't show the tax rate on the refunds form (and as stated before, I'm not sure why you need to, bearing in mind it can't ever be any different).
Given the above, I think the most straightforward option is the 'hidden grid' which is visible when you click 'all refunds' (and which also hides the 'edit' and 'delete' buttons);  in effect, it becomes a display only 'all refunds' grid.
Derek.

Thank you very much guys.....................
Truly appreciated..............................

Derek:
With your approach you missed hiding refund edit and delete buttons plus disabling double click for refund tGrids. I added them. Downside is that in order to edit refunds, user needs to click on edit button as disabling doubleclick applies to both all refunds and normal states. There may be a code using if etc so that double click disabled only when all refunds are displayed. I didn't try anything on this front yet.

There is one issue I noticed tho, All refunds displays more records then what's shown on invoice tGid. PI Invoice tGrid contains 5 refund records but PIR Refunds tGrid shows 8 refund records. Perhaps MVD search doing something that we cannot see as EHW pointed out?

EHW:
Nice one... It works fine without workarounds. I wish I could write SQL script like you can.

Hi Derek,

If I'm not missing something, the following image may explain the issue better hopefully:

I agree EHW's solution is the proper one and I'll use it in this case.
I also like your workarounds too. It'll be useful for other projects not only mine but also other MVD users' too. That's why I highlighted the above issue.

Hi Derek,

You are absolutely right on both points. Thank you very much for taking time to look into my sample project.... Truly appreciated.............
If there are more design issues you spot please let me know.

Solutions I can think of...
1. Prevent moving purchase inv to sale inv if purchase inv contains refund/s. If purchase inv contains only partial refunds and user still wants to sell what's left then user needs to create a new purchase invoice for the same product.

2. Traceability; display purchase invoice details on sale and sale refund invs forms or on separate form via a buttons on sale and sale invs reforms.

I didn't commit any changes yet before having your view. Probably you have better solutions.

The reason I'm converting purchase inv to sale inv rather than having them separately is that this part of the project involves 1 product transactions hence there is no qty field. In and out.

Yes.

Hi EHW,

Thanks for the alternative approach example......

On this project, I'm using single product invoicing. Purchases tGrid also acts as a inventory. So once a product sold it moves into sales invoices.
Derek was kind enough to highlight shortcomings in my design.

I have added a message box for the purchase invoice contains "Db" refunds to the btnSaleAdd with a cancel which stops user converting purch inv with refund/s to sale inv. If all refunds were full this would be it but sometimes there are partial refunds where product may be kept. Supplier may give some refund rather than having product returned and issuing full refun in some occasions. We end up with a product at new purchase price (original purchase price - refund). In accounting terms (as far as I know) we can sell it as a new product at discount, if we cannot then it has to be written off in order to balance the books, alternatively it may be kept as an asset depending on product nature. I'm not going into write offs, asset management etc with this project. Trying to keep it simple and basic.

On traceability front, having purchase inv key fields displayed on sale inv could solve the issue imho. When sale inv viewed, user can see the details of the original purch inv on sale inv form. I have done all these and they seems to be functioning ok so far. However, one thing I couldn't do. Instead of using combos and textboxes, for supplier name and address, I wanted display the in a read only memo field. Please see the reference image below:

Thanks a lot EHW..............

Unfortunately, I'm not there yet to construct proper SQL.

I tried followings under frmInvoice onShow but surely they didn't work as they are not correct:

frmInvoice.memSIsupplier.Lines.add(frmInvoice.name.id_Supplier);
frmInvoice.memSIsupplier.Lines.add(frmInvoice.Street.id_Supplier);

frmInvoice.memSIsupplier.Lines.add := SQLExecute('SELECT Name FROM Supplier WHERE id='+inttostr(form1.tgMainSaleInvs.dbitemid));
frmInvoice.memSIsupplier.Lines.add := SQLExecute('SELECT Street FROM Supplier WHERE id='+inttostr(form1.tgMainSaleInvs.dbitemid));